[CI] Separated Out NightlyTests #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated out the NightlyTests from the regular tests. This separation makes sense since the NightlyTests take so much longer to run and are run on different machines. This makes it easier to configure when these tests are run in the future (especially if we need to change the testing machines and do not want these tests to run as often). Also made them run nightly instead of on push to master or PRs since they are currently not working. Once they start working again, we can re-enable this feature if we want.
|
@vaughnbetz This PR separates out the NightlyTests from the regular Tests. This also turns off the NightlyTests from running on PR for now while we fix the issue with CI (so people can more easily tell when their code is not working). Please review. |
|
Seems OK to me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated out the NightlyTests from the regular tests. This separation makes sense since the NightlyTests take so much longer to run and are run on different machines. This makes it easier to configure when these tests are run in the future (especially if we need to change the testing machines and do not want these tests to run as often).
Also made them run nightly instead of on push to master or PRs since they are currently not working. Once they start working again, we can re-enable this feature if we want.
This builds off issue #2652 . This should help bring the CI back up (at least getting some of the tests running).