Conversation
Owner
|
This looks like a very heavy handed approach, the original suggestion on #58 was a one line change. Any other windows people care to comment on this? |
Author
|
It is heavy because it was the easiest way to hide & show the cursor and also clear the line in the windows console. You can also choose to go down the path where in windows platform the cursor is always visible and the line is never cleared. The only problem I saw with that solution is that the display of eta_td becomes a nuance (the printed string is bigger in the beginning and smaller at the end, leaving old characters at the end of the output) . |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #58
This is the first draft of a working fix for a windows console support of a progress bar.