updated home page UI and contents #112
Conversation
|
Can you center the images for each one of these
|
|
For these, I think we'd like the titles up the top and the subtitles in a smaller font down the bottom inside the images. I see that they are SVGs though. Are you able to edit them or do we need Excited top do that?
|
@nick-verida, I can't edit the SVG images, I think we will need excited to do that. |
@nick-verida, I have fixed this section as well . |
src/pages/index.js
Outdated
| {gettingStarted.map((item) => ( | ||
| <div className={styles.storeButtons}> | ||
| <div className={styles.storeButtonsChild}> | ||
| <a href={item.link}> |
There was a problem hiding this comment.
It doesn't look like the image are clickable links.
@nick-verida all the other links/buttons in this page are with a box and linear gradient background, how about having a similar look? (noting it might too much)
src/pages/index.js
Outdated
| const gettingStarted = [ | ||
| { | ||
| title: | ||
| "Implement the Single Sign On and Client SDK Javascript SDKs in your application", |
There was a problem hiding this comment.
I don't get the "... Client SDK Javascript SDKs ...".
@nick-verida, what is the official name we should use while referring to the SDK(s)? We sometimes use "Verida Javascript Library", like in the API doc
My understanding is:
The Client SDK is available for 3 platforms with the following packages:
- @verida/client-ts (javascript/typescript)
- @verida/client-node (node js)
- @verida/client-rn (react native)
The SSO SDK is available through the following package:
- @verida/account-web-vault
Am I correct?
Should we standardise how we refer to them in the whole documentation?
There was a problem hiding this comment.
@aurelticot depends on the context. In this case it was pretty deliberate because someone in the "getting started" phrase doesn't yet understand the distinction, and we want them to look at both.
There was a problem hiding this comment.
Hmm, I still don't get the sentence in the doc. If the target is someone that doesn't yet understand the distinction, I find "... Client SDK Javascript SDKs ..." pretty confusing.
How about simply: "Implement the SDKs in your application"?
We should ask them them to remove the text from the SVG, as well as the surrounding box and gradient background. |
|
Additional note regarding the style. |
… the share the same HTML structure #108
There was a problem hiding this comment.
We lost the cards in the Getting Started section. I haven't seen a comment about it, I guess it was not intentional but due to bringing the latest develop into this feature branch.
When you're making a merge commit, please don't add other changes in it (other than resolving conflicts) and call the commit something like "merge develop into feature/...". It really help understand what happened.
- 1 inline comment
@aurelticot,
Sure, noted |
Yes we did. As per the requirements in the original issue #108 the Getting Started should have 3 boxes for the Stores, the SDKs and the Vue Starter Kit. You implemented them but 2 of them are missing since |
Where are we on getting Excited to rework the images? @cmcWebCode40 @nick-verida |
@cmcWebCode40 can you have a look at this again? |
Demo
https://www.loom.com/share/ba26bf42a464424a9b9bf066bcce99aa
@nick-verida, do you think the icons I have used for the getting started section are good enough ?
maybe excited could design one for this purpose?
closes #108