-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile-time generation of RTM API wrapper #6
Open
vergenzt
wants to merge
12
commits into
master
Choose a base branch
from
meta
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also splits rtm-scala into rtm-scala and rtm-scala-lib.
...with four temporary differences from the manual implementation: 1. All arguments are accepted as strings. This will be worked around by having a mapping from argument names to domain types. 2. Return values are all HttpRequests; in other words, `.as[T]` must be called manually with the desired return type. This will also be remedied with a mapping, this time from method name to return type. 3. Timelines and Transactions do not have client-side functionality any more. Haven't put any thought into whether or how that will happen yet. 4. `rtm.tasks.notes.*` are not contained in an object `notes` nested within `RtmApi.tasks`. The actual method names are `notes.add`, `.delete`, and `.edit`. Surround the name with backticks to use it from Scala.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #5.