Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfe): allow @vercel/microfrontends to be considered a MFE package dependency #9493

Merged

Conversation

mknichel
Copy link
Member

@mknichel mknichel commented Nov 22, 2024

Description

This PR allows @vercel/microfrontends to be considered a MFE dependency in addition to @vercel/micro-frontends-internal.

Testing Instructions

@mknichel mknichel requested a review from a team as a code owner November 22, 2024 01:47
@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label Nov 22, 2024
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 1:47am
8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:47am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:47am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:47am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:47am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:47am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:47am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:47am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 1:47am

Copy link
Member

@tknickman tknickman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're too fast!

@mknichel mknichel changed the title feat(mfe): Allow @vercel/microfrontends to be considered a MFE package dependency feat(mfe): allow @vercel/microfrontends to be considered a MFE package dependency Nov 22, 2024
@mknichel mknichel enabled auto-merge (squash) November 22, 2024 02:06
@mknichel mknichel merged commit c183599 into main Nov 22, 2024
40 of 41 checks passed
@mknichel mknichel deleted the mknichel/mfe-allow-vercel-microfrontends-package-name branch November 22, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants