Add Vim Motions Support to TurboRepo UI Input Handling #9243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-orchestrator
bot
added
needs: triage
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@AlvaroParker is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
|
Don't really know why the workflows are failing. I updated my branch, waiting for approval : ) |
|
hey just to keep you in the loop, I was reviewing this just now and we're gonna talk about it at our next team meeting and get back to you: there are some future plans for some of these keys (beyond just |
|
hey @AlvaroParker so I checked with the rest of the team and we'd like to just do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces support for basic Vim-style key bindings within the
tuicomponent of TurboRepo, specifically for pane navigation. The goal is to improve navigation efficiency for users familiar with Vim-like key motions.Key Changes:
h,j,k, andlVim keybinds for interactive mode:Ctrl+h: Exit interactive mode.Ctrl+j: Move down.Ctrl+k: Move up.Ctrl+l: Enter interactive mode.j: Move down.k: Move up.l: Enter interactive mode.Motivation:
Adding these motions provides a more intuitive interface for users familiar with Vim commands, enhancing navigation within the pane section of the TurboRepo UI.
Related discussion