Skip to content

fix(example): staging Dockerfile using production env #85310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from
Open

fix(example): staging Dockerfile using production env #85310

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2a62c3
fix(example): staging Dockerfile using production env
giuliobracci Oct 24, 2025
6a09c49
Merge branch 'canary' into fix/with-docker-multi-env-example
giuliobracci Oct 24, 2025
87d898f
Merge branch 'canary' into fix/with-docker-multi-env-example
giuliobracci Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/with-docker-multi-env/docker/staging/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ WORKDIR /app
COPY --from=deps /app/node_modules ./node_modules
COPY . .
# This will do the trick, use the corresponding env file for each environment.
COPY .env.staging.sample .env.production
COPY .env.staging.sample .env.staging
Copy link
Contributor

@vercel vercel bot Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Dockerfile is incorrectly copying the staging environment file to the production environment, causing staging environments to use production configurations.

View Details

Analysis

What fails: The COPY .env.staging.sample .env.production instruction in the staging Dockerfile copies staging configuration to the production configuration file, causing staging environments to use production settings

How to reproduce:

# The issue exists in line 28 of:
examples/with-docker-multi-env/docker/staging/Dockerfile

Result: The staging environment uses production configuration because during Docker build time, .env.staging.sample is copied directly into .env.production, overwriting production settings with staging configuration

Expected: The staging environment should use its own configuration file (.env.staging) as specified in the Dockerfile's COPY instruction. Instead of:

COPY .env.staging.sample .env.production

it should be:

COPY .env.staging.sample .env.staging

This ensures that the staging environment uses the correct staging-specific configuration settings and production environments use their proper production configurations as intended.

Copy link
Member

@ijjk ijjk Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Staging is not a env config filename Next.js loads automatically so this file will not be used

x-ref:

next.js/packages/next-env/index.ts

Line 137 in 5312936

const mode = isTest ? 'test' : dev ? 'development' : 'production'

Copy link
Author

@giuliobracci giuliobracci Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ijjk thanks for the clarification

RUN npm run build

# 3. Production image, copy all the files and run next
Expand Down
Loading