Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removes 'version' attribute post deprecation #67236

Open
wants to merge 3 commits into
base: canary
Choose a base branch
from

Conversation

khawajaJunaid
Copy link

@khawajaJunaid khawajaJunaid commented Jun 27, 2024

What?

removes 'version' attribute post deprecation from all compose files related to dev, staging and prod env

Why?

latest updates in docker compose no longer requires 'version' attribute

How?

remove the version field in the compose files to remove the warning that one may get during builds

@ijjk ijjk added the examples Issue/PR related to examples label Jun 27, 2024
@ijjk
Copy link
Member

ijjk commented Jun 27, 2024

Allow CI Workflow Run

  • approve CI run for commit: 205c807

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@eps1lon
Copy link
Member

eps1lon commented Jun 27, 2024

latest updates in docker compose no longer requires 'version' attribute

Which update?

@khawajaJunaid
Copy link
Author

latest updates in docker compose no longer requires 'version' attribute

Which update?

In the docker compose yml format, it mentions that the version attribute has been deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants