Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 12-third-party-libraries.mdx #67142

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Update 12-third-party-libraries.mdx #67142

merged 3 commits into from
Jul 21, 2024

Conversation

allanchau
Copy link
Contributor

What?

This PR aims to provide some clarification on what the dataLayer prop does.

Why?

https://nextjs.org/docs/app/building-your-application/optimizing/third-party-libraries#options

Data layer array to instantiate the container with. Defaults to an empty array.

There seems to be 2 problems with this description when viewing the code https://github.com/vercel/next.js/blob/canary/packages/third-parties/src/google/gtm.tsx#L40-L45:

  1. There is no default.
  2. The dataLayer prop should be an object that is then pushed to the dataLayer array.

@ijjk ijjk added the Documentation Related to Next.js' official documentation. label Jun 24, 2024
@ijjk
Copy link
Member

ijjk commented Jun 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: 72b6786

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Jun 24, 2024

Allow CI Workflow Run

  • approve CI run for commit: 72b6786

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Contributor

@delbaoliveira delbaoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @allanchau 🙏🏼

@leerob leerob merged commit 3338947 into vercel:canary Jul 21, 2024
33 checks passed
@github-actions github-actions bot added the locked label Aug 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants