Implemented missing pieces for overriding 404 and 500 pages. #10
+25
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauchg
approved these changes
Oct 15, 2016
nkzawa
reviewed
Oct 16, 2016
| import React from 'react' | ||
| export default ({ statusCode }) => ( | ||
| <p>An error { statusCode } occurred</p> | ||
| ) |
Contributor
There was a problem hiding this comment.
I don't like to give specific predefined props for _error.js.
Instead, I think you can just add getInitialProps and get statusCode as props if you want.
export default class Error extends React.Component {
static getInitialProps ({ res, xhr }) {
const statusCode = res ? res.statusCode : xhr.status
return { statusCode }
}
...
}
Contributor
Author
There was a problem hiding this comment.
#12 Revert this and adds this example to the readme
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.