Remove numpy from nextjs-flask to fix broken builds #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip fails to install this dependency on Python 3.12 vercel#946 While fixing the error is certainly one way of going about it, numpy is not even used for the hello-world Flask app this ships with. To simplify things, this commit removes numpy as a dependency entirely.
sup
requested review from
okbel,
lfades,
goncy,
dominiksipowicz,
leerob and
lpalmes
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@sup is attempting to deploy a commit to the Vercel Examples Team on Vercel. A member of the Team first needs to authorize it. |
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: pypi/[email protected]) |
sup
changed the title
This was referenced Sep 12, 2024
|
@dferber90 It's a bit quiet around here, but can I interest you in a review of a simple fix for a broken example? 👀 |
leerob
approved these changes
Sep 15, 2024
|
Thank you @sup! I was out of office and just came back 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pip fails to install this dependency on Python 3.12
While fixing the root cause of the error is certainly one way of going about it, numpy is not even used for the hello-world Flask app this ships with. To simplify things, this commit removes numpy as a dependency entirely.
Demo URL
https://automaton-seven.vercel.app/
Type of Change
New Example Checklist
Not applicable
npm run new-examplewas used to create the example