feat(dev): isolate requests in parent-owned workers#760
Closed
ctgowrie wants to merge 4 commits into
Closed
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
ctgowrie
force-pushed
the
feat/dev-parent-worker-transport
branch
from
feaf376 to
135761c
Compare
ctgowrie
force-pushed
the
feat/dev-generation-artifacts
branch
from
1a5e322 to
c0c3030
Compare
ctgowrie
force-pushed
the
feat/dev-parent-worker-transport
branch
from
0974216 to
b80e5e1
Compare
ctgowrie
force-pushed
the
feat/dev-parent-worker-transport
branch
from
b80e5e1 to
4e2aafa
Compare
ctgowrie
force-pushed
the
feat/dev-generation-artifacts
branch
from
c0c3030 to
4d02fe3
Compare
Signed-off-by: Casey Gowrie <ctgowrie@gmail.com>
Third-party dependencies inlined into a generation bundle can import `@workflow/*` (e.g. `@ai-sdk/provider-utils` -> `@workflow/serde`). eve vendors those packages, so leaving the import external emits a bare specifier no materialized generation can resolve. Externalize workflow runtime imports only for authored importers and inline them inside bundled node_modules code. Also exclude the channel identity plugin from generation bundles so an immutable artifact structurally cannot read the process-global channel cache, and split the package boundary plugins into their own module. Signed-off-by: Casey Gowrie <ctgowrie@gmail.com>
Signed-off-by: Casey Gowrie <ctgowrie@gmail.com>
…s exchange exists A throw between admission and exchange construction left the lease held with no socket listener to release it, so a retired worker with that lease could never close. Signed-off-by: Casey Gowrie <ctgowrie@gmail.com>
ctgowrie
force-pushed
the
feat/dev-generation-artifacts
branch
from
4d02fe3 to
9535d97
Compare
ctgowrie
force-pushed
the
feat/dev-parent-worker-transport
branch
from
4e2aafa to
7dec777
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Nitro currently owns both the public dev listener and its reloadable runtime. Replacing that runtime can reset admitted HTTP or WebSocket traffic, lose the original client address, and make shutdown wait on streams whose producer has not stopped.
What changed
Validation
Stack
Depends on #759 (immutable generation artifacts). Stage 4 will make watcher, pointer, route, and worker promotion one transaction. Stage 5 will move the local Workflow World and queue ownership into the parent and add durable generation references plus pruning.