Skip to content

proxy function for improved readability#1475

Open
Sujaicodes wants to merge 1 commit intovercel:mainfrom
Sujaicodes:patch-5
Open

proxy function for improved readability#1475
Sujaicodes wants to merge 1 commit intovercel:mainfrom
Sujaicodes:patch-5

Conversation

@Sujaicodes
Copy link
Copy Markdown

logic remains exactly the same, but we reduce redundant operations, avoid repeated URL parsing, and make it slightly more efficient.
Avoid repeated URL parsing — origin is destructured from request.nextUrl and reused.
Single redirectUrl computation — done once upfront.
Simplified conditions — combined pathname checks to reduce nesting.
Minimal variable usage — reduces memory footprint slightly.
Logic fully preserved — guest redirect, auth redirect, and ping handling remain identical.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 1, 2026

@Sujaicodes is attempting to deploy a commit to the Templates Test vtest314 Team on Vercel.

A member of the Team first needs to authorize it.

Comment on lines +21 to +22
// Precompute redirect URL once
const redirectUrl = encodeURIComponent(pathname);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Precompute redirect URL once
const redirectUrl = encodeURIComponent(pathname);
// Precompute redirect URL once (prepend base because nextUrl.pathname strips basePath)
const redirectUrl = encodeURIComponent(`${base}${pathname}`);

Guest sign-in redirects to wrong path when basePath is configured because request.nextUrl.pathname strips the basePath from the redirect URL.

Fix on Vercel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant