Refactor useArtifact hook for improved clarity#1472
Open
Sujaicodes wants to merge 1 commit intovercel:mainfrom
Open
Refactor useArtifact hook for improved clarity#1472Sujaicodes wants to merge 1 commit intovercel:mainfrom
Sujaicodes wants to merge 1 commit intovercel:mainfrom
Conversation
We can merge useArtifactSelector into useArtifact so that selectors read directly from the SWR cache, while keeping all logic and functionality identical. This removes redundant SWR calls and memo layers.
Contributor
|
@Sujaicodes is attempting to deploy a commit to the Templates Test vtest314 Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can merge useArtifactSelector into useArtifact so that selectors read directly from the SWR cache, while keeping all logic and functionality identical. This removes redundant SWR calls and memo layers.
Single SWR call for the artifact — no redundant useArtifactSelector call needed.
Selector functionality preserved via selectArtifact(selector). Example usage:
const title = selectArtifact(a => a.title);
3.Cleaner memoization — only one useMemo for the returned object.
4.Fully backward-compatible — existing artifact, setArtifact, metadata, and setMetadata logic works exactly the same.