fix(tunnel): queue chunks that arrive mid-dial instead of dialing again - #14
Merged
Conversation
The tunnel has no explicit open message: the first data chunk for an unknown connection ID is what opens it, and the receiving side only registered the ID after its dial returned. Any further chunk for that ID arriving during the dial (Node's HTTP/2 client sends the preface and the first request frames ~1-2ms apart) spawned another dial for the same connection, splitting the stream across two sockets. The peer saw a preface on one socket and headers on the other and simply never answered, so the caller hung until its own deadline instead of getting an error. Register a buffering placeholder for the ID synchronously on the recv pump, dial off the pump, then swap the real connection in and flush the queued chunks in order. A peer error that lands while the dial is in flight now also closes the dialed socket instead of leaking it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Replace the tunnel-private pendingConn with a reusable BufferedReadWriteCloser in pkg/ioutil: an io.ReadWriteCloser that buffers writes until Set attaches the underlying one, then flushes them as a single write and passes everything through. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.