Upgrade xsync dependency to v4 and update Map API usage - #11
Open
chimanjain wants to merge 1 commit into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Author
|
Can the reviewers please verify these changes! |
Signed-off-by: Chiman Jain <chimanjain15@gmail.com>
chimanjain
force-pushed
the
upgrade-xsync-v4
branch
from
August 25, 2026 16:13
0358bc8 to
e2a7607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the
github.com/puzpuzpuz/xsyncdependency fromv3tov4and updates all concurrent map usages across the codebase to the updatedv4generic APIs.In
xsyncv4, the library has removed the older non-generic structures and consolidated the generic map underxsync.Map.Note
Low Risk
Mechanical dependency and type renames on concurrent maps; behavior should match v3 for the same Load/Store/Range usage, with low change surface beyond the library bump.
Overview
Bumps
github.com/puzpuzpuz/xsyncfrom v3.5.1 to v4.5.0 and aligns call sites with the v4 generic map API:xsync.MapOf/NewMapOfbecomexsync.Map/NewMap.That rename is applied everywhere concurrent maps back proxy networking state: connection tracking (
pkg/conntrack), IP allocation (pkg/ippool), Kubernetes port-forward dialer caching (pkg/k8s/k8spf), and tunnel multiplexed connections (pkg/tunnel).go.sumis updated accordingly. The only non-mechanical change is minorslog.Debugformatting in conntrack cleanup.Reviewed by Cursor Bugbot for commit 0358bc8. Bugbot is set up for automated code reviews on this repo. Configure here.