Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Error resulting from hard cast from readable to writable #5078

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

This is just another example of why as X is evil and shouldn't ever be used. A Readable was being cast to a Writable.

I stuck a button in my test app with

	<button
		onclick={() => {
			console.log('adding tool result');
			addToolResult({
				toolCallId: 'call_wLJFuAcFfygtlxd3nAtYRpt8',
				result: { location: 'Denver, CO', temperature: 68 }
			});
		}}>Add Tool Result</button
	>

on main this causes the failure reported in the #5056 comments. With this branch, the error is gone and everything seems to be working correctly.

@wookiehangover
Copy link
Contributor

thanks for the fix on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants