Factor out common code to address issue #11 #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created new common package to house shared utilities - Analyzed code duplication across comid and corim packages - Extracted TaggedURI type to common package - Updated comid/entity.go to use common.TaggedURI via type alias - Maintained backward compatibility with existing code - Added comprehensive documentation in common/README.md - All tests pass successfully Fixes veraison#11 Signed-off-by: Sukuna0007Abhi <[email protected]>
Sukuna0007Abhi
force-pushed
the
gg-update
branch
from
1726d1c to
e972d41
Compare
setrofim
requested changes
Oct 13, 2025
| return o == "" | ||
| } | ||
| // TaggedURI is a type alias for common.TaggedURI for backward compatibility. | ||
| type TaggedURI = common.TaggedURI |
Contributor
There was a problem hiding this comment.
Do not do this. Update the endire code base to use common.TaggedURI instead.
| @@ -0,0 +1,88 @@ | |||
| # Common Package | |||
Contributor
There was a problem hiding this comment.
Remove this file -- this should not be part of the code, as it addresses changes made at a specific point in time.
Instead, some of this should be documented inside the commmit messages (and some things probably don't need to be documente at all as they are self-evident in the commmit diff).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11