Skip to content

Conversation

@joydeep049
Copy link
Contributor

@joydeep049 joydeep049 commented Aug 19, 2025

The AuthorizedBy field in CoSWIDEvidenceMap and Measurement was initially only one cryptokey, but it should be an array of cryptokeys.

This PR makes the above change and makes all subsequent required changes throughout the codebase.

Local Tests Passed ✔️

cc @thomas-fossati @yogeshbdeshpande @jraman567

Signed-off-by: joydeep049 <[email protected]>
@yogeshbdeshpande
Copy link
Contributor

Thank you @joydeep049 For awesome work. I will review it.

In the mean time, please check:
https://github.com/veraison/corim/blob/main/comid/cryptokeys.go

and consider re-using the type defined here, to make it more clear and concise!

@joydeep049
Copy link
Contributor Author

I have already made changes throughout the codebase, reusing the cryptokeys array wherever it was used. Am I missing something?
@thomas-fossati @yogeshbdeshpande

@yogeshbdeshpande
Copy link
Contributor

I have already made changes throughout the codebase, reusing the cryptokeys array wherever it was used. Am I missing something? @thomas-fossati @yogeshbdeshpande

@joydeep049 : Please see the Merged PR: #219

This is how the type CryptoKeys will be a good way to use the existing type

@yogeshbdeshpande
Copy link
Contributor

I have already made changes throughout the codebase, reusing the cryptokeys array wherever it was used. Am I missing something? @thomas-fossati @yogeshbdeshpande

@joydeep049 : Please see the Merged PR: #219

This is how the type CryptoKeys will be a good way to use the existing type

I think, there is some more remaining changes in the base CoMID library, you can address the usage their, I suppose using this PR..

@joydeep049
Copy link
Contributor Author

Looks like this issue was already solved by PR 219.
So I'm gonna close this!

@joydeep049 joydeep049 closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants