-
Notifications
You must be signed in to change notification settings - Fork 32
Fix PublicKey extraction from JWK #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
deeglaze
wants to merge
3
commits into
veraison:main
Choose a base branch
from
deeglaze:jwkpk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+81
−46
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,7 +51,6 @@ linters: | |
| - misspell | ||
| - revive | ||
| - staticcheck | ||
| - typecheck | ||
| - unconvert | ||
| - unused | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,34 @@ | ||
| module github.com/veraison/corim | ||
|
|
||
| go 1.22.0 | ||
| go 1.23.0 | ||
|
|
||
| toolchain go1.24.2 | ||
|
|
||
| require ( | ||
| github.com/fxamacker/cbor/v2 v2.5.0 | ||
| github.com/google/uuid v1.3.0 | ||
| github.com/lestrrat-go/jwx/v2 v2.0.21 | ||
| github.com/lestrrat-go/jwx/v3 v3.0.6 | ||
| github.com/spf13/cast v1.4.1 | ||
| github.com/stretchr/testify v1.9.0 | ||
| github.com/stretchr/testify v1.10.0 | ||
| github.com/veraison/eat v0.0.0-20210331113810-3da8a4dd42ff | ||
| github.com/veraison/go-cose v1.2.1 | ||
| github.com/veraison/swid v1.1.1-0.20230911094910-8ffdd07a22ca | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/davecgh/go-spew v1.1.1 // indirect | ||
| github.com/decred/dcrd/dcrec/secp256k1/v4 v4.2.0 // indirect | ||
| github.com/goccy/go-json v0.10.2 // indirect | ||
| github.com/decred/dcrd/dcrec/secp256k1/v4 v4.4.0 // indirect | ||
| github.com/goccy/go-json v0.10.3 // indirect | ||
| github.com/kr/pretty v0.2.0 // indirect | ||
| github.com/lestrrat-go/blackmagic v1.0.2 // indirect | ||
| github.com/lestrrat-go/blackmagic v1.0.4 // indirect | ||
| github.com/lestrrat-go/httpcc v1.0.1 // indirect | ||
| github.com/lestrrat-go/httprc v1.0.5 // indirect | ||
| github.com/lestrrat-go/iter v1.0.2 // indirect | ||
| github.com/lestrrat-go/httprc/v3 v3.0.0 // indirect | ||
| github.com/lestrrat-go/option v1.0.1 // indirect | ||
| github.com/lestrrat-go/option/v2 v2.0.0 // indirect | ||
| github.com/pmezard/go-difflib v1.0.0 // indirect | ||
| github.com/segmentio/asm v1.2.0 // indirect | ||
| github.com/x448/float16 v0.8.4 // indirect | ||
| golang.org/x/crypto v0.31.0 // indirect | ||
| golang.org/x/sys v0.28.0 // indirect | ||
| golang.org/x/sys v0.33.0 // indirect | ||
| gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter bizarrely crashes around here with the error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PrivateKey extends PublicKey in ecdsa, so maybe it doesn't like that they're both tested in the same switch. Even if it's legal to the Golang typechecker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the attempt (9a86440). Unfortunately, we now have two errors rather than one :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we use
staticcheckinstead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created a PR to fix all the linter problems except the documentation lint that I can rebase on top of when it's merged.