Support custom error handlers #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will concatenate the contents of each file together to form a single template, which will then be rendered once.
This will concatenate the contents of each Consul key together to form a single template, which will then be rendered once. This will also concatenate the contents of single or multiple files if present. Consul keys are concatenated after files.
mmartell37
changed the title
mmartell37
force-pushed
the
custom-error
branch
from
0cd0328 to
782fadb
Compare
sixfeetover
force-pushed
the
safe-rerender
branch
from
22d3c3c to
42b83ad
Compare
|
This was closed accidentally due to deleting the base branch. |
|
This needs to be rebased on the latest master due to our merging the other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress based on #16, partially addressing #13.
The desire is to allow custom error handling as defined by the caller and to provide a few basic error handers.
An example handler class is provided for testing as well as a very basic default which simply displays the error message.
Currently, caller-specified error handlers may be ignored at initial render. See below.
To do:
Consult.render!is executed.