Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe re-rendering #13

Open
sixfeetover opened this issue Sep 25, 2018 · 0 comments
Open

Safe re-rendering #13

sixfeetover opened this issue Sep 25, 2018 · 0 comments

Comments

@sixfeetover
Copy link
Member

Support safely re-rendering templates, meaning if an exception is thrown during render, don't overwrite the previously rendered template.

Example situation:

  • You have a Rails database.yml file being rendered by Consult.
  • In production, your application boots successfully, rendering database.yml.
  • The next process that boots throws an exception for whatever reason, and the app fails to launch as a result

Instead of the app failing to launch, we should allow for graceful (and reported - meaning, the error makes it to Rollbar or whatever) failure, so the app can boot with the previously rendered template.

Questions:

  1. Should this be configurable on a per-template basis?
  2. Should this be the default behavior?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants