Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundler 2+ does not work with the current demo. #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bundler 2+ does not work with the current demo. #1

wants to merge 2 commits into from

Conversation

mmartell37
Copy link

No description provided.

@mmartell37 mmartell37 requested a review from sixfeetover March 15, 2019 12:41
@sixfeetover
Copy link
Member

We don't need to preserve 1.16 here. Instead I'd recommend just running bundle update --bundler with 1.17.3 installed and then committing that change. The resulting diff should update the Gemfile.lock to say BUNDLED WITH 1.17.3. Bundler 2.0 will use 1.17 files successfully.

@mmartell37
Copy link
Author

Seems to work with 2.0.1 fine, actually.

@sixfeetover
Copy link
Member

Thanks - the readme change shouldn't be necessary anymore with the gemfile update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixfeetover sixfeetover Awaiting requested review from sixfeetover

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmartell37 @sixfeetover