use querystring rather than mustache templates; support extra attributes in custom providers #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @veltman. Thanks for building this repository. I've made two changes which I wanted to share, but I don't think they are ready to be merged. So please feel free to close this PR or add your comments on if you think the intent is a good direction and if it warrants further work, or if you're not keen on integrating these changes (that's absolutely fine).
The first commit here uses
querystringrather than mustache templates. I ran into a bug where if the mustache variable was in the query string and contained a'(apostrophe) the URL wouldn't be created correctly based on the template. Using thequerystringmodule fixed that for me. But adds significant complexity to the user interface. ~~~It also drops support for concatenating columns in the URL. (fixed in latest commit)~~~The second is for custom providers to return more than just
lat,lng, such that any extra attributes returned are simply added to the output CSV.