feat: improve datanode snapshot creation #11396
Draft
+507
−56
Commits on Jul 8, 2024
-
feat: improve datanode snapshot creation
As of now, the snapshot are created in a sequential and blocking way in the datanode. This means that while a snapshot is being taken, no block can be processed. The following approach is made: - the database is locked with a transaction - queries are generated - one by one the query are: - executed - the result piped into the file system - finally the lock is released, and later the files are added to ipfs. The bottle neck here is that the results are being save on the fs as they arrive, which is unecessary and amount for 95% of the time spent snapshoting (and so blocking anything else). To prevent this, we keep those results from the database in buffers, and only save them to file via a worker go routine. Cache buffer size in datanode snapshot. Signed-off-by: Jeremy Letang <[email protected]>
-
Signed-off-by: Jeremy Letang <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.