chore: updates to test for 0053-PERP-028 #11300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
chore/correct-053-PERP-028
branch
from
d18f7bd
to
f21ef9a
Compare
wwestgarth
approved these changes
May 20, 2024
witgaw
approved these changes
May 20, 2024
cdummett
force-pushed
the
chore/correct-053-PERP-028
branch
from
f21ef9a
to
58d398b
Compare
cdummett
force-pushed
the
chore/correct-053-PERP-028
branch
from
58d398b
to
5a3224a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test previously used an asset with zero decimal places meaning internal and external TWAPs could only be expressed as integers. Result, internal and external TWAPs were rounded to 9 and 10 so misconfigured timings did not cause the test to fail and changes as a result of core ticket #10360 were not visible.
PR updates test allowing internal and external TWAPs to be expressed as 9.875 (9875) and 10.250 (10250) respectively. If ticket #10360 is implemented, will be trivial to update test and check behaviour is correct.
Final TWAP diff alliging with spec: