fix: ensure ELS is updated when LP is cancelled

Signed-off-by: Elias Van Ootegem <[email protected]>

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### 🐛 Fixes
 
 - [10960](https://github.com/vegaprotocol/vega/issues/10960) - Only the owner of a referral set can update it.
+- [10950](https://github.com/vegaprotocol/vega/issues/10950) - Fix bug that caused cancelled liquidity provisions to stick around after opening auction.
 
 ## 0.75.1
 

core/execution/common/liquidity_provision.go

@@ -661,6 +661,12 @@ func (m *MarketLiquidity) CancelLiquidityProvision(ctx context.Context, party st
 			return err
 		}
 	}
+	// remove ELS for the cancelled LP if cancellation was applied immediately (e.g. during opening auction)
+	if applied {
+		m.equityShares.SetPartyStake(party, amendment.CommitmentAmount)
+		// force update for all shares
+		_ = m.equityShares.AllShares()
+	}
 
 	return nil
 }

core/execution/common/liquidity_provision_test.go

@@ -610,6 +610,8 @@ func TestCancelLiquidityProvisionDuringOpeningAuction(t *testing.T) {
 		}).
 		AnyTimes()
 
+	testLiquidity.equityShares.EXPECT().SetPartyStake(provider, gomock.Any()).Times(1)
+	testLiquidity.equityShares.EXPECT().AllShares().Times(1).Return(nil)
 	err = testLiquidity.marketLiquidity.CancelLiquidityProvision(ctx, provider)
 	assert.NoError(t, err)