feat: update referral program for new requirements #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/referral_updates
branch
from
5ba2ef8
to
69d4e6d
Compare
barnabee
reviewed
Aug 29, 2023
|
This computation is wrong: party_epoch_notional_taker_volume =
party_epoch_notional_taker_volume +
- (trade_price * trade_size * settlement_asset_quantum)
+ (trade_price * trade_size / settlement_asset_quantum) |
cdummett
force-pushed
the
feat/referral_updates
branch
from
3b3efc4
to
33bf42c
Compare
cdummett
force-pushed
the
feat/referral_updates
branch
from
1ccdd02
to
ff6d920
Compare
barnabee
approved these changes
Aug 29, 2023
ValentinTrinque
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR updates specs touched by the referral program as per the additional requirements specified in #1912.