feat: referral rewards are paid to the original referrer #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/fix_refererral_reward_destination
branch
from
5cd97d5
to
66656db
Compare
cdummett
force-pushed
the
feat/fix_refererral_reward_destination
branch
from
66656db
to
d00afc7
Compare
barnabee
reviewed
Aug 7, 2023
Yes this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, referral rewards are generated by each referee and paid to the creator of their current referral set. Since, parties are free to move between referral sets, their is no guarantee rewards generated by a referee will be paid to the original party who actually referred the user to the network.
Changes
PR updates the spec so when a referral code is applied for the first time, the referee becomes permanently associated with the referrer. Referral rewards will now always be paid out to this referrer regardless of whether the party changes referral set.
Note, a party will contribute to their current referral sets volume and their benefit factors will be set using their current referral sets running volume.