Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction list in portfolio #6101

Open
20 of 35 tasks
JonRay15 opened this issue Mar 26, 2024 · 1 comment · May be fixed by #6476
Open
20 of 35 tasks

Transaction list in portfolio #6101

JonRay15 opened this issue Mar 26, 2024 · 1 comment · May be fixed by #6476
Assignees
Labels
branch-develop Work for the next planned release of frontend apps

Comments

@JonRay15
Copy link
Contributor

JonRay15 commented Mar 26, 2024

Story

As a user
I want to see a full list of transactions I have made
So that I know what I have done

Acceptance Criteria

Note; this ticket is a stepping stone to a large rework of the portfolio page, but for now we will aim to create the transaction list simply in teh current AG grid structure. After this we can move it into the new design Joelle is working on.

  • Modify the Collateral / Deposits / Withdrawals table in Portfolio to be Collateral & Transaction List, where this list combines all of deposits, transfers and withdrawals into a single structure
  • Need a way to fetxh some number of deposits, withdrawals and transfers for the connected key and order them by timestamp descending, such that we can load more if needed and dont lose any rows
  • A list of all transactions showing the following columns
    • Type (deposit, transfer in, transfer out, withdrawal)
    • Asset code (looked up from assets API)
    • Datetime
    • Amount (converted with asset decimals from assets API)
    • To / From
    • Status
  • To / From field will be conditional
    • For deposit it will always be the source ERC20 address
    • For transfer TO the current key show the sender Vega key
    • For transfer FROM the current key show the recipient Vega key
    • For withdrawal show the ERC20 address
  • Status will also be conditional
    • For deposit:
      • Show "Pending (X / Y Confirmations)"
      • Then show "Complete"
    • For withdrawal
      • Show "Pending - approve in wallet" while waiting for wallet
      • Then "Pending - sent from network" once a txHash is available
      • Then "Complete - received on target network" once a ref is available (i think)
    • For transfer
      • Show "Pending - approve in wallet" while waiting for wallet
      • Then "Complete" once done ... dont think it is worth an interim message when its so fast
  • Should be possible to filter on the type to view only deposits / transfer / withdrawals
  • There is currently a consditional "deposit" and "make withdrawal" button .... remove these since there will be a new panel due to Portfolio interim changes #6267
  • Make sure we are showing all withdrawals correctly; there is a suspision in mainnet currently that we're doing something wrong here and hence not showing failed withdrawals ... but with extra Console validation now its very hard to verify this
    • Must ensure if there are STATUS_REJECTED withdrawals we are showing them... this might mean we need to be able to sign withdrawals under the required minimum and send them so Core fails them instead of Console / VegaWallet
    • Must ensure we're showing STATUS_OPEN withdrawals when they appear ... this will be very brief since it only lasts the time it takes the validators to process, but we need to show it
    • If it is STATUS_FINALISED and there is no txHash that means it has not been finalised on ethereum and we need to show a status for this, and a prompt to "Complete withdrawal"
    • IF it is STATUS_FINALISED and has a txHash then it is fully complete
  • Ensure that transfers both TO and FROM are shown
  • Ensure that pending and failed / rejected withdrawals are shown
  • Show the chain name in brackets after the asset code

Sketch

Suggest the easiest way to initially build this thing is to enhance the current table which shows collateral / deposits / withdrawals

That way we can do the backend work and just dump it into new tabe here.

Image

Then in the long term Joelle is doing a redesign of this page to land on somethign more like the below.

image

Additional details / background info

Summary of logic:

image

@mattrussell36 mattrussell36 changed the title Transaction list in asset Transaction list in portfolio Apr 18, 2024
@JonRay15 JonRay15 added the branch-develop Work for the next planned release of frontend apps label Apr 30, 2024
@mattrussell36 mattrussell36 self-assigned this May 22, 2024
@mattrussell36
Copy link
Collaborator

@JonRay15 I don't think its worthwhile showing a pending state for transfers. There isn't a great way to acheive this and the value is super low

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-develop Work for the next planned release of frontend apps
Projects
Status: InProg
2 participants