Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure clarity around USDT Ethereum vs Arbitrum #6464

Closed
17 of 23 tasks
JonRay15 opened this issue May 23, 2024 · 3 comments · Fixed by #6521
Closed
17 of 23 tasks

Ensure clarity around USDT Ethereum vs Arbitrum #6464

JonRay15 opened this issue May 23, 2024 · 3 comments · Fixed by #6521
Assignees
Labels
branch-develop Work for the next planned release of frontend apps

Comments

@JonRay15
Copy link
Contributor

JonRay15 commented May 23, 2024

The Chore

  • Needs to be clear the difference between the two; anywhere that code is used more info might be needed to make sure it was obvious
  • If a user is on a market which needs USDT Eth and they have USDT Arb make it clear that they can swap them or vice versa
  • If you're being prompted to deposit from a given market for which you have no assets we will currently default everyething to the actual asset (ie. USDT ETH in the short term) and really we might want to offer more options at this point
  • Any other deposit entry points??

NB. I think we need to see where Art has got to with the cross asset flows before we can say for sure what needs to happen here so I want to see this in the wild asap.

Acceptance criteria

Trading screen

  • Anywhere the asset icon is used it needs to use the full asset-chain icon if it does not already
  • If the user has no balance of the required asset but they have some of an asset which can be swapped for the required asset using an existing spot market we should display an additional button showing "Swap for asset" Swap signposting #6520
  • If user clicks "Swap for asset" button it should open the simple swap UI in the sidebar and default the received asset appropriately to receive the asset needed for that market (doing this in the sidebar might require Support deposit / transfer / swap etc from within the trading sidebar #6459 to be complete) Swap signposting #6520
  • Leave the pay asset blank and let the user set it manually Swap signposting #6520
  • Settlement asset in the header add the chain in brackets after the symbol, eg. Arb or Eth
  • Collateral table add the chain in brackets after the symbol
  • Where the pill shows USDT (and allows you to swap size / notional) it needs to include the chain in brackets

Deposit screen - Should be done by Art's PR

  • Add icons (including the chain icon) to the asset dropdown here
  • Change "Ethereum deposit cap" to just "Deposit cap" and ensure we are taking that from the appropriate chain
  • 'From Ethereum address' label needs to be more generic/specific

Withdraw screen - Should be done by Art''s PR

  • Add all icons including chain icon to asset dropdown etc
  • Ensure withdrawal limits / thresholds work for Arbitrum bridge too
  • Probably we need to revisit this once we find out what Art has got up to building in the squid SDK to the withdraw flow.... ideally we'd have some messaging highlighting that withdrawing to Arbitrum will be cheaper for fees
  • 'To Ethereum address' label needs to be more generic/specific

Cross chain deposit - Should be covered by #6507

  • Full icon including chain is supported
  • Chain is shown in brackets after the name

Transfer screen

  • Add all icons including chain icon to asset dropdown etc
  • Append chain name in brackets

Portfolio screen

  • In the new transaction list we should show the chain name in brackets after the asset code Moved to Transaction list in portfolio #6101
  • Ledger entries the asset dropdown shoudl include the chain name in brackets after asset code

Rewards screen

  • In the rewards history we should show the chain name in brackets after the asset code
  • On the reward cards when a dispatch strategy is scoped to a settlement asset include the asset chain in brackets

Competitions screen

  • On the game cards when a dispatch strategy is scoped to a settlement asset include the asset chain in brackets

Additional details / background info

image

@JonRay15 JonRay15 self-assigned this May 23, 2024
@JonRay15 JonRay15 added the branch-develop Work for the next planned release of frontend apps label May 30, 2024
@JonRay15 JonRay15 assigned JonRay15 and unassigned JonRay15 Jun 5, 2024
@mattrussell36 mattrussell36 self-assigned this Jun 10, 2024
@JonRay15
Copy link
Contributor Author

I guess this info box needs to have the chain in brackets too?

image

And as per #6491 this should include both assets for spot markets ... but I dont think that is done yet.

@JonRay15
Copy link
Contributor Author

JonRay15 commented Jun 11, 2024

It feels strange to me that the only thing on this ticket that seems to support the chain ID is the size / notional switcher.

image

I think we tried to avoid putting it EVERYWHERE ... but in the USDT Arb v USDT Eth market you kind of need it or you just cant make sense of it. I suspect the right thing here is to have different behaviour on SPOT vs FUTR / PERP.

FUTR / PERP

  • Just do the asset in the header (and it will be in collateral as thats market agnostic)
  • Everything in the deal ticket doesnt need it because the odds of having a USDT<>USDT PERP/FUTR is basically zero ... as long as the header has it you're fine

SPOT:
I think we want to add it bloody everywhere .... all across the deal ticket:

  • The size / notional switcher pill (done)
  • The price pill
  • The notional / size (which toggles based on the which you're using above)
  • Fees
  • The actual submit button
    • If Market its only once "1.01 USDT (Arb) @Market"
    • If Limit its twice "100 USDT (Arb) @ 1.01 USDT (Eth)"
  • Available collateral

@JonRay15
Copy link
Contributor Author

We seem to have some recurrence of that weird "no accounts" bug appearing in the collateral table? Dont know if its related or just we havent noticed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-develop Work for the next planned release of frontend apps
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants