refactor: Update pyproject.toml, fix lints, typing
#10
Conversation
Still hardcoded as it isn't a trivial switch to f-strings. Need to resolve nested quoting and braces
Was deprecated in `(3, 9)` but removed in later versions
| @@ -90,7 +93,7 @@ def test_altairplotdirective(app): | |||
| // embed when document is loaded, to ensure vega library is available | |||
| // this works on all modern browsers, except IE8 and older | |||
| document.addEventListener("DOMContentLoaded", function(event) { | |||
| var spec = {"config": {"view": {"continuousWidth": 300, "continuousHeight": 300}}, "data": {"values": [{"x": "A", "y": 5}, {"x": "B", "y": 3}, {"x": "C", "y": 6}, {"x": "D", "y": 7}, {"x": "E", "y": 2}]}, "mark": {"type": "bar"}, "encoding": {"x": {"field": "x", "type": "nominal"}, "y": {"field": "y", "type": "quantitative"}}, "$schema": "https://vega.github.io/schema/vega-lite/v5.8.0.json"}; | |||
| var spec = {"config": {"view": {"continuousWidth": 300, "continuousHeight": 300}}, "data": {"values": [{"x": "A", "y": 5}, {"x": "B", "y": 3}, {"x": "C", "y": 6}, {"x": "D", "y": 7}, {"x": "E", "y": 2}]}, "mark": {"type": "bar"}, "encoding": {"x": {"field": "x", "type": "nominal"}, "y": {"field": "y", "type": "quantitative"}}, "$schema": "https://vega.github.io/schema/vega-lite/v5.20.1.json"}; | |||
There was a problem hiding this comment.
Ideally these wouldn't be set manually, but fixing that can happen in another PR.
|
@binste I'm not sure how clear the commit trail is, but all of the changes I've made in
There should be no functional differences (assuming the current test suite is sufficient) |
There was a problem hiding this comment.
Thanks, LGTM! Didn't spot any issues with the changes, commits were clear, and it's great to have the code bases more aligned :) This repo hasn't gotten much attention since we took it out of the Altair repo.
I leave the PR open in case you want to drop Python 3.8 support at the same time. up to you.
Thanks @binste
EditOnly one fix, which was a version guard I added earlier in this PR. |
Resolves #9