-
Notifications
You must be signed in to change notification settings - Fork 7
feat(telemetry): implement custom serialization for telemetry ids #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
ed54e1e to
c0ffbb7
Compare
Change SummaryThis PR adds custom Issues FoundFound 3 issues that should be addressed: 🔴 Critical
🟡 Important
All issues have inline comments with suggested fixes. |
Add custom `Display`, `FromStr`, `Serialize`, and `Deserialize` implementations for `ProcessId`, `ThreadId`, `ExecutionId`, and `SpanContext` types. These provide a consistent hex-encoded string format with colon separators for composite IDs (`process:thread` for `ExecutionId`, `process:span` for `SpanContext`). This makes telemetry ids more readable and provides a unified format for logging and serialization. Signed-off-by: Wim Looman <[email protected]>
Signed-off-by: Wim Looman <[email protected]>
c0ffbb7 to
22ef8b0
Compare
HectorMRC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add custom
Display,FromStr,Serialize, andDeserializeimplementations forProcessId,ThreadId, andSpanContexttypes.These provide a consistent hex-encoded string format with colon separators for composite IDs (
process:threadforThreadId,process:spanforSpanContext). This makes telemetry ids more readable and provides a unified format for logging and serialization.