docs(external): CONTRIBUTING.md enhancements #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pront
added
the
no-changelog
jszwedko
reviewed
Jan 3, 2025
| 7. [Submit the branch as a pull request][urls.submit_pr] to the repo. A team member should | ||
| comment and/or review your pull request. | ||
| 8. Add a changelog fragment (requires the PR number) to describe your changes which will | ||
| be included in the release changelog. See the [README.md](changelog.d/README.md) for details. | ||
| 9. It is normal to have multiple review iterations on a PR. To enable incremental reviews, please try to avoid force pushing if possible. |
jszwedko
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few enhancements to the contribution guide.
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
our guidelines.
Checklist
run
dd-rust-license-tool writeand commit the changes. More details here.References