Draft: adapt Vector to VRL ObjectMap#25649
Draft
lukesteensen wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adapts Vector to the experimental VRL
ObjectMapwork by replacing directBTreeMapassumptions withObjectMap-compatible construction and iterationpatterns.
VRL dependency used for this draft:
d243198bc134ab19ea6293322d36055fd54c2fe2Commit structure
The main ObjectMap work is isolated in:
refactor: adapt Vector to VRL ObjectMapchore: use git VRL ObjectMap dependencyThis branch also includes two small test fixes that were discovered while
testing the ObjectMap changes locally, but are otherwise unrelated to ObjectMap:
test(codecs): avoid mutating global log schema in syslog testslog_schemastate, which can polluteother tests depending on execution order.
test(vector-core): keep empty DDSketch fixtures canonicalround-trip expectations.
Benchmark support is included separately in:
chore(bench): add ObjectMap benchmark helpersValidation
Passed:
cargo fmt --all -- --checkcargo check --workspace --all-targets --all-features --lockedmake check-clippycargo test -p vector-core --all-features --lib --lockedcargo test -p codecs --all-features --lib --lockedobject_maptestsBenchmark sanity check:
datadog_agent_remap_blackholebtree-> currentflat:+24.43%--replicates 1 --total-samples 60 --warmup-seconds 15