chore(deps): Bump Rust version to 1.81.0 #21509

bruceg · 2024-10-15T16:57:01Z

Includes a load of automated changes and a couple surprises.

jszwedko

Nice, thank you!

jszwedko · 2024-10-15T17:36:37Z

src/sinks/aws_s_s/sink.rs

-#[derive(Clone, Copy, Debug, Default)]
-pub(crate) struct SqsSinkDefaultBatchSettings;
-
-impl SinkBatchSettings for SqsSinkDefaultBatchSettings {


I'm wondering if we meant to use these 🤔

Maybe we meant to, but it is completely unused now and so causing a complaint.

jszwedko · 2024-10-15T17:37:22Z

src/sources/aws_s3/sqs.rs

            })
-            .map_err(|err| {


I'm happy to see inspect_err finally 🎉

buraizu

Approving with a minor suggestion

buraizu · 2024-10-15T22:21:32Z

website/cue/reference/components/sources/base/statsd.cue

@@ -64,7 +64,7 @@ base: components: sources: statsd: configuration: {
 			Whether or not to sanitize incoming statsd key names. When "true", keys are sanitized by:
 			- "/" is replaced with "-"
 			- All whitespace is replaced with "_"
-			- All non alphanumeric characters [^a-zA-Z_\\-0-9\\.] are removed.
+			- All non alphanumeric characters (A-Z, a-z, 0-9, _, or -) are removed.


Suggested change

- All non alphanumeric characters (A-Z, a-z, 0-9, _, or -) are removed.

- All non-alphanumeric characters (A-Z, a-z, 0-9, _, or -) are removed.

* chore(deps): Bump Rust version to 1.81.0 * Fix statsd docs * Regen docs

github-actions · 2024-10-16T00:49:30Z

Regression Detector Results

Run ID: 396e51a3-82c7-4d63-b4c7-5fed67a2fbad Metrics dashboard

Baseline: 7f379b9
Comparison: 4966e39

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI	links
❌	otlp_grpc_to_blackhole	ingress throughput	-5.80	[-5.98, -5.61]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	file_to_blackhole	egress throughput	-1.62	[-5.79, +2.54]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	+3.76	[+3.65, +3.88]
➖	splunk_hec_route_s3	ingress throughput	+2.49	[+2.18, +2.80]
➖	syslog_splunk_hec_logs	ingress throughput	+2.26	[+2.15, +2.36]
➖	fluent_elasticsearch	ingress throughput	+1.84	[+1.30, +2.39]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	+1.72	[+1.56, +1.88]
➖	syslog_humio_logs	ingress throughput	+1.70	[+1.58, +1.83]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+1.24	[+1.10, +1.38]
➖	datadog_agent_remap_blackhole	ingress throughput	+0.86	[+0.74, +0.97]
➖	syslog_loki	ingress throughput	+0.14	[+0.02, +0.25]
➖	syslog_log2metric_humio_metrics	ingress throughput	+0.12	[-0.02, +0.26]
➖	http_to_http_json	ingress throughput	+0.01	[-0.04, +0.05]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	+0.00	[-0.02, +0.02]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	-0.00	[-0.02, +0.02]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.03, +0.02]
➖	http_to_http_acks	ingress throughput	-0.00	[-0.49, +0.49]
➖	http_to_http_noack	ingress throughput	-0.01	[-0.07, +0.05]
➖	http_text_to_http_json	ingress throughput	-0.03	[-0.16, +0.10]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	-0.04	[-0.17, +0.08]
➖	socket_to_socket_blackhole	ingress throughput	-0.24	[-0.32, -0.16]
➖	otlp_http_to_blackhole	ingress throughput	-0.97	[-1.07, -0.86]
➖	file_to_blackhole	egress throughput	-1.62	[-5.79, +2.54]
➖	http_to_s3	ingress throughput	-1.77	[-1.93, -1.62]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	-2.23	[-2.43, -2.03]
➖	http_elasticsearch	ingress throughput	-2.26	[-2.45, -2.07]
➖	datadog_agent_remap_datadog_logs	ingress throughput	-3.50	[-3.65, -3.35]
❌	otlp_grpc_to_blackhole	ingress throughput	-5.80	[-5.98, -5.61]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

github-actions · 2024-10-16T01:57:05Z

Regression Detector Results

Run ID: 65c60064-a724-4882-9c1b-e952856582ed Metrics dashboard

Baseline: d2f855c
Comparison: 6dded24

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI	links
❌	socket_to_socket_blackhole	ingress throughput	-8.01	[-8.07, -7.94]
❌	otlp_http_to_blackhole	ingress throughput	-11.28	[-11.36, -11.20]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	file_to_blackhole	egress throughput	+3.09	[-1.06, +7.24]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
➖	syslog_log2metric_humio_metrics	ingress throughput	+3.44	[+3.30, +3.58]
➖	file_to_blackhole	egress throughput	+3.09	[-1.06, +7.24]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	+2.99	[+2.90, +3.08]
➖	syslog_humio_logs	ingress throughput	+1.72	[+1.60, +1.83]
➖	fluent_elasticsearch	ingress throughput	+1.62	[+1.08, +2.16]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	+0.72	[+0.62, +0.83]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	+0.71	[+0.58, +0.85]
➖	syslog_splunk_hec_logs	ingress throughput	+0.57	[+0.50, +0.64]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+0.02	[-0.07, +0.12]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	+0.00	[-0.13, +0.14]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	+0.00	[-0.02, +0.03]
➖	http_to_http_noack	ingress throughput	+0.00	[-0.05, +0.06]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	+0.00	[-0.02, +0.02]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	-0.00	[-0.02, +0.02]
➖	http_to_http_json	ingress throughput	-0.01	[-0.06, +0.04]
➖	http_to_http_acks	ingress throughput	-0.02	[-0.51, +0.47]
➖	datadog_agent_remap_blackhole	ingress throughput	-0.13	[-0.21, -0.05]
➖	http_text_to_http_json	ingress throughput	-0.46	[-0.57, -0.35]
➖	splunk_hec_route_s3	ingress throughput	-1.07	[-1.37, -0.78]
➖	http_to_s3	ingress throughput	-1.61	[-1.76, -1.45]
➖	syslog_loki	ingress throughput	-1.91	[-1.97, -1.85]
➖	datadog_agent_remap_datadog_logs	ingress throughput	-2.79	[-2.98, -2.59]
➖	otlp_grpc_to_blackhole	ingress throughput	-2.81	[-2.98, -2.63]
➖	http_elasticsearch	ingress throughput	-2.98	[-3.14, -2.83]
❌	socket_to_socket_blackhole	ingress throughput	-8.01	[-8.07, -7.94]
❌	otlp_http_to_blackhole	ingress throughput	-11.28	[-11.36, -11.20]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

github-actions · 2024-10-16T02:44:00Z

Regression Detector Results

Run ID: cc646484-1712-40c6-8c2a-c7e7a1dfb27d Metrics dashboard

Baseline: af59045
Comparison: 7cc3d6d

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI	links
✅	syslog_humio_logs	ingress throughput	+5.28	[+5.13, +5.42]
❌	otlp_http_to_blackhole	ingress throughput	-5.87	[-5.95, -5.79]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	file_to_blackhole	egress throughput	+1.56	[-2.70, +5.82]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	syslog_humio_logs	ingress throughput	+5.28	[+5.13, +5.42]
➖	syslog_log2metric_humio_metrics	ingress throughput	+2.78	[+2.67, +2.89]
➖	fluent_elasticsearch	ingress throughput	+2.57	[+2.03, +3.10]
➖	splunk_hec_route_s3	ingress throughput	+2.09	[+1.80, +2.38]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	+1.57	[+1.48, +1.66]
➖	file_to_blackhole	egress throughput	+1.56	[-2.70, +5.82]
➖	syslog_loki	ingress throughput	+1.47	[+1.40, +1.55]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	+1.47	[+1.30, +1.63]
➖	http_elasticsearch	ingress throughput	+0.90	[+0.72, +1.08]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+0.84	[+0.77, +0.91]
➖	syslog_regex_logs2metric_ddmetrics	ingress throughput	+0.77	[+0.61, +0.94]
➖	http_to_http_acks	ingress throughput	+0.07	[-0.42, +0.56]
➖	http_to_http_json	ingress throughput	+0.00	[-0.04, +0.05]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	+0.00	[-0.04, +0.04]
➖	http_to_http_noack	ingress throughput	-0.00	[-0.05, +0.05]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.00	[-0.02, +0.02]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	-0.00	[-0.02, +0.02]
➖	syslog_splunk_hec_logs	ingress throughput	-0.13	[-0.21, -0.05]
➖	http_text_to_http_json	ingress throughput	-0.49	[-0.63, -0.36]
➖	socket_to_socket_blackhole	ingress throughput	-0.66	[-0.74, -0.59]
➖	datadog_agent_remap_datadog_logs	ingress throughput	-1.38	[-1.52, -1.24]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	-1.40	[-1.48, -1.31]
➖	http_to_s3	ingress throughput	-2.16	[-2.31, -2.01]
➖	otlp_grpc_to_blackhole	ingress throughput	-3.28	[-3.47, -3.09]
➖	datadog_agent_remap_blackhole	ingress throughput	-3.39	[-3.49, -3.29]
❌	otlp_http_to_blackhole	ingress throughput	-5.87	[-5.95, -5.79]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

github-actions · 2024-10-16T03:02:36Z

Regression Detector Results

Run ID: 2e233596-fe49-445e-86ee-29538864d473 Metrics dashboard

Baseline: 650e6b2
Comparison: 7054ae0

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

Significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	syslog_regex_logs2metric_ddmetrics	ingress throughput	+8.75	[+8.47, +9.03]
✅	fluent_elasticsearch	ingress throughput	+5.67	[+5.12, +6.22]
❌	socket_to_socket_blackhole	ingress throughput	-8.85	[-8.91, -8.79]
❌	otlp_http_to_blackhole	ingress throughput	-11.91	[-11.98, -11.83]

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	file_to_blackhole	egress throughput	-0.41	[-4.49, +3.67]

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI
✅	syslog_regex_logs2metric_ddmetrics	ingress throughput	+8.75	[+8.47, +9.03]
✅	fluent_elasticsearch	ingress throughput	+5.67	[+5.12, +6.22]
➖	syslog_log2metric_humio_metrics	ingress throughput	+2.48	[+2.34, +2.62]
➖	syslog_log2metric_splunk_hec_metrics	ingress throughput	+1.91	[+1.81, +2.01]
➖	datadog_agent_remap_datadog_logs	ingress throughput	+1.69	[+1.52, +1.86]
➖	datadog_agent_remap_blackhole_acks	ingress throughput	+1.64	[+1.52, +1.75]
➖	syslog_splunk_hec_logs	ingress throughput	+1.63	[+1.54, +1.72]
➖	splunk_hec_route_s3	ingress throughput	+1.56	[+1.25, +1.87]
➖	syslog_log2metric_tag_cardinality_limit_blackhole	ingress throughput	+1.23	[+1.14, +1.33]
➖	syslog_humio_logs	ingress throughput	+0.55	[+0.42, +0.68]
➖	otlp_grpc_to_blackhole	ingress throughput	+0.20	[+0.02, +0.39]
➖	http_to_http_acks	ingress throughput	+0.05	[-0.44, +0.54]
➖	http_to_http_json	ingress throughput	+0.01	[-0.03, +0.05]
➖	splunk_hec_indexer_ack_blackhole	ingress throughput	+0.00	[-0.02, +0.02]
➖	splunk_hec_to_splunk_hec_logs_acks	ingress throughput	-0.00	[-0.03, +0.03]
➖	http_to_http_noack	ingress throughput	-0.00	[-0.05, +0.05]
➖	splunk_hec_to_splunk_hec_logs_noack	ingress throughput	-0.00	[-0.02, +0.02]
➖	http_text_to_http_json	ingress throughput	-0.11	[-0.23, +0.01]
➖	datadog_agent_remap_datadog_logs_acks	ingress throughput	-0.24	[-0.36, -0.13]
➖	file_to_blackhole	egress throughput	-0.41	[-4.49, +3.67]
➖	syslog_loki	ingress throughput	-0.48	[-0.56, -0.40]
➖	datadog_agent_remap_blackhole	ingress throughput	-0.91	[-0.99, -0.83]
➖	http_to_s3	ingress throughput	-2.14	[-2.32, -1.97]
➖	http_elasticsearch	ingress throughput	-2.96	[-3.13, -2.80]
❌	socket_to_socket_blackhole	ingress throughput	-8.85	[-8.91, -8.79]
❌	otlp_http_to_blackhole	ingress throughput	-11.91	[-11.98, -11.83]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

bruceg added type: tech debt A code change that does not add user value. dependencies Pull requests that update a dependency file no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Oct 15, 2024

bruceg requested a review from a team as a code owner October 15, 2024 16:57

jszwedko approved these changes Oct 15, 2024

View reviewed changes

chore(deps): Bump Rust version to 1.81.0

67959f1

bruceg force-pushed the bruceg/bump-rust-1.81 branch from 8f98aa3 to 67959f1 Compare October 15, 2024 18:24

bruceg enabled auto-merge October 15, 2024 18:32

bruceg added 2 commits October 15, 2024 13:49

Fix statsd docs

6cc475d

Regen docs

0967dff

bruceg requested review from a team as code owners October 15, 2024 20:51

github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Oct 15, 2024

bruceg added this pull request to the merge queue Oct 15, 2024

buraizu approved these changes Oct 15, 2024

View reviewed changes

github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2024

chore(deps): Bump Rust version to 1.81.0 (#21509)

4966e39

* chore(deps): Bump Rust version to 1.81.0 * Fix statsd docs * Regen docs

jszwedko removed this pull request from the merge queue due to a manual request Oct 16, 2024

jszwedko added this pull request to the merge queue Oct 16, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): Bump Rust version to 1.81.0 #21509

chore(deps): Bump Rust version to 1.81.0 #21509

bruceg commented Oct 15, 2024

jszwedko left a comment

jszwedko Oct 15, 2024

bruceg Oct 15, 2024

jszwedko Oct 15, 2024

buraizu left a comment

buraizu Oct 15, 2024

github-actions bot commented Oct 16, 2024

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

github-actions bot commented Oct 16, 2024

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

github-actions bot commented Oct 16, 2024

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

github-actions bot commented Oct 16, 2024

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

	- All non alphanumeric characters (A-Z, a-z, 0-9, _, or -) are removed.
	- All non-alphanumeric characters (A-Z, a-z, 0-9, _, or -) are removed.

chore(deps): Bump Rust version to 1.81.0 #21509

Are you sure you want to change the base?

chore(deps): Bump Rust version to 1.81.0 #21509

Conversation

bruceg commented Oct 15, 2024

jszwedko left a comment

Choose a reason for hiding this comment

jszwedko Oct 15, 2024

Choose a reason for hiding this comment

bruceg Oct 15, 2024

Choose a reason for hiding this comment

jszwedko Oct 15, 2024

Choose a reason for hiding this comment

buraizu left a comment

Choose a reason for hiding this comment

buraizu Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 16, 2024

Regression Detector Results

Significant changes in experiment optimization goals

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

github-actions bot commented Oct 16, 2024

Regression Detector Results

Significant changes in experiment optimization goals

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

github-actions bot commented Oct 16, 2024

Regression Detector Results

Significant changes in experiment optimization goals

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation

github-actions bot commented Oct 16, 2024

Regression Detector Results

Significant changes in experiment optimization goals

Experiments ignored for regressions

Fine details of change detection per experiment

Explanation