-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: instanceof Uint8Array
does not work correctly for vitest
' env jsdom
#1531
Conversation
string
and correct Uint8Array
for CommonJS bundleinstanceof Uint8Array
does not work correctly for the CommonJS bundle
…/vechain-sdk-js into fix/1424-ensuring-string
instanceof Uint8Array
does not work correctly for the CommonJS bundleinstanceof Uint8Array
does not work correctly for vitest
' env jsdom
can we add similar test on our side ? (like the one from the original issue) |
hi @leszek-vechain just added in the last couple of commits a config to run Hope this is enough for you :p . We can build on top of this, since all the vite tests will have both configs. |
I also added an |
Description
All details in the issue comments.
Closes #1424.
Type of change
How Has This Been Tested?
Go to this branch in DappKit and run the tests as described in the issue. Keep in mind that, in order for them to work:
yarn build
) the core package in the SDKTest Configuration:
Checklist: