Add first tests #863
Open
Add first tests #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #863 +/- ##
==========================================
- Coverage 62.65% 62.64% -0.01%
==========================================
Files 208 209 +1
Lines 18926 18946 +20
==========================================
+ Hits 11858 11869 +11
- Misses 5970 5979 +9
Partials 1098 1098 ☔ View full report in Codecov by Sentry. |
| @@ -650,6 +699,28 @@ func TestValidateBlockBody(t *testing.T) { | |||
| assert.Equal(t, err, expected) | |||
| }, | |||
| }, | |||
| { | |||
| "EmptyTx", func(t *testing.T) { | |||
There was a problem hiding this comment.
Maybe this can be renamed to ZeroGasTx since it's focusing on sending a tx with 0 gas
There was a problem hiding this comment.
other than ^ looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.