NEW JSON, #274
NEW JSON, #274
Conversation
There was a problem hiding this comment.
Hey @dgutierrez1987 can you update both title and description to something suitable?
Anyway, thanks for the PR. As you can see the CI is failing and this is because we require all the folders inside apps to be lowercase. This means com.NFBC => com.nfbc. Please apply such changes so we can have this merged.
PS: You may have an hard time having git recognizing the case change. I suggest to rename the folder to something like com.temp => commit => rename to com.nfbc => commit
Also, I see lot of contracts listed, are these all actually used by your app ? testnet + mainnet ?
|
Hello,
I will work on the name change now. These SCs are used by the application,
they are mint contracts for books. I thought to include them all so that
the NFT images can be seen in the wallet as well. Or is there another
method to ensure those NFTs are viewable?
Working now on name change.
Thank you!
David
…On Mon, Jun 24, 2024 at 1:53 PM Erik Nucibella ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hey @dgutierrez1987 <https://github.com/dgutierrez1987> can you update
both title and description to something suitable?
Anyway, thanks for the PR. As you can see the CI is failing and this is
because we require all the folders inside apps to be lowercase. This means
com.NFBC => com.nfbc. Please apply such changes so we can have this
merged.
PS: You may have an hard time having git recognizing the case change. I
suggest to rename the folder to something like com.temp => commit =>
rename to com.nfbc => commit
Also, I see lot of contracts listed, are these all used by your app ? Are
these testnet + mainnet ?
PS
—
Reply to this email directly, view it on GitHub
<#274 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3P25TEO7NGBFYZXXGRWK4LZJCBNHAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZWG4ZDKMJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
naming convention incorrect
|
dgutierrez1987#2
Deleted the old folder and created this pull request.
…On Mon, Jun 24, 2024 at 1:53 PM Erik Nucibella ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hey @dgutierrez1987 <https://github.com/dgutierrez1987> can you update
both title and description to something suitable?
Anyway, thanks for the PR. As you can see the CI is failing and this is
because we require all the folders inside apps to be lowercase. This means
com.NFBC => com.nfbc. Please apply such changes so we can have this
merged.
PS: You may have an hard time having git recognizing the case change. I
suggest to rename the folder to something like com.temp => commit =>
rename to com.nfbc => commit
Also, I see lot of contracts listed, are these all used by your app ? Are
these testnet + mainnet ?
PS
—
Reply to this email directly, view it on GitHub
<#274 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3P25TEO7NGBFYZXXGRWK4LZJCBNHAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZWG4ZDKMJQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Cool! The contract addresses here are actually not related to the visibility of nfts in veworld wallet. |
|
Ok you got it. I will make this change as soon as I arrive to my pc.
On Tue, Jun 25, 2024, 12:20 AM Erik Nucibella ***@***.***>
wrote:
… Hello, I will work on the name change now. These SCs are used by the
application, they are mint contracts for books. I thought to include them
all so that the NFT images can be seen in the wallet as well. Or is there
another method to ensure those NFTs are viewable? Working now on name
change. Thank you! David
… <#m_-3552984325407709945_>
On Mon, Jun 24, 2024 at 1:53 PM Erik Nucibella *@*.*> wrote: @.**
requested changes on this pull request. Hey @dgutierrez1987
<https://github.com/dgutierrez1987> https://github.com/dgutierrez1987 can
you update both title and description to something suitable? Anyway, thanks
for the PR. As you can see the CI is failing and this is because we require
all the folders inside apps to be lowercase. This means com.NFBC =>
com.nfbc. Please apply such changes so we can have this merged. PS: You may
have an hard time having git recognizing the case change. I suggest to
rename the folder to something like com.temp => commit => rename to
com.nfbc => commit Also, I see lot of contracts listed, are these all used
by your app ? Are these testnet + mainnet ? PS — Reply to this email
directly, view it on GitHub <#274 (review)
<#274 (review)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3P25TEO7NGBFYZXXGRWK4LZJCBNHAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZWG4ZDKMJQGI
. You are receiving this because you were mentioned.Message ID: *@*.***>
Cool! The contract addresses here are actually not related to the
visibility of nfts in veworld wallet.
Also, i see they are causing some issues with the validation. Can you just
remove the key from the json ? In general, they are not use for any purpose
at the moment. Thanks
—
Reply to this email directly, view it on GitHub
<#274 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3P25TCFTYBO4ZSVOKFC6Y3ZJEK4NAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGE3DMMJZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I amended the JSON:
dgutierrez1987#3
On Tue, Jun 25, 2024 at 7:45 AM David Gutierrez ***@***.***>
wrote:
… Ok you got it. I will make this change as soon as I arrive to my pc.
On Tue, Jun 25, 2024, 12:20 AM Erik Nucibella ***@***.***>
wrote:
> Hello, I will work on the name change now. These SCs are used by the
> application, they are mint contracts for books. I thought to include them
> all so that the NFT images can be seen in the wallet as well. Or is there
> another method to ensure those NFTs are viewable? Working now on name
> change. Thank you! David
> … <#m_-3012568720688307151_m_-3552984325407709945_>
> On Mon, Jun 24, 2024 at 1:53 PM Erik Nucibella *@*.*> wrote: @.**
> requested changes on this pull request. Hey @dgutierrez1987
> <https://github.com/dgutierrez1987> https://github.com/dgutierrez1987
> can you update both title and description to something suitable? Anyway,
> thanks for the PR. As you can see the CI is failing and this is because we
> require all the folders inside apps to be lowercase. This means com.NFBC =>
> com.nfbc. Please apply such changes so we can have this merged. PS: You may
> have an hard time having git recognizing the case change. I suggest to
> rename the folder to something like com.temp => commit => rename to
> com.nfbc => commit Also, I see lot of contracts listed, are these all used
> by your app ? Are these testnet + mainnet ? PS — Reply to this email
> directly, view it on GitHub <#274 (review)
> <#274 (review)>>,
> or unsubscribe
> https://github.com/notifications/unsubscribe-auth/A3P25TEO7NGBFYZXXGRWK4LZJCBNHAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZWG4ZDKMJQGI
> . You are receiving this because you were mentioned.Message ID: *@*.***>
>
> Cool! The contract addresses here are actually not related to the
> visibility of nfts in veworld wallet.
> Also, i see they are causing some issues with the validation. Can you
> just remove the key from the json ? In general, they are not use for any
> purpose at the moment. Thanks
>
> —
> Reply to this email directly, view it on GitHub
> <#274 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A3P25TCFTYBO4ZSVOKFC6Y3ZJEK4NAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGE3DMMJZGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
I think you just deleted the entire folder. Please add it again with the requested changes. |
|
You are correct. I started a new one. I am sorry to have made such a mess
of this process. Are you able to see my new one:
dgutierrez1987#3 ?
[image: image.png]
On Tue, Jun 25, 2024 at 8:37 AM Erik Nucibella ***@***.***>
wrote:
… I amended the JSON: dgutierrez1987#3
<dgutierrez1987#3> On Tue, Jun
25, 2024 at 7:45 AM David Gutierrez *@*.
*> wrote: … <#m_-2488641353945901901_> Ok you got it. I will make this
change as soon as I arrive to my pc. On Tue, Jun 25, 2024, 12:20 AM Erik
Nucibella @.*> wrote: > Hello, I will work on the name change now. These
SCs are used by the > application, they are mint contracts for books. I
thought to include them > all so that the NFT images can be seen in the
wallet as well. Or is there > another method to ensure those NFTs are
viewable? Working now on name > change. Thank you! David > …
<#m_-3012568720688307151_m_-3552984325407709945_> > On Mon, Jun 24, 2024 at
1:53 PM Erik Nucibella *@*.*> wrote: @.** > requested changes on this
pull request. Hey @dgutierrez1987 <https://github.com/dgutierrez1987> >
https://github.com/dgutierrez1987 <https://github.com/dgutierrez1987>
https://github.com/dgutierrez1987 <https://github.com/dgutierrez1987> > can
you update both title and description to something suitable? Anyway, >
thanks for the PR. As you can see the CI is failing and this is because we
> require all the folders inside apps to be lowercase. This means com.NFBC
=> > com.nfbc. Please apply such changes so we can have this merged. PS:
You may > have an hard time having git recognizing the case change. I
suggest to > rename the folder to something like com.temp => commit =>
rename to > com.nfbc => commit Also, I see lot of contracts listed, are
these all used > by your app ? Are these testnet + mainnet ? PS — Reply to
this email > directly, view it on GitHub <#274
<#274> (review) > <#274 (review)
<#274 (review)>>>,
> or unsubscribe >
https://github.com/notifications/unsubscribe-auth/A3P25TEO7NGBFYZXXGRWK4LZJCBNHAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZWG4ZDKMJQGI
<https://github.com/notifications/unsubscribe-auth/A3P25TEO7NGBFYZXXGRWK4LZJCBNHAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMZWG4ZDKMJQGI>
> . You are receiving this because you were mentioned.Message ID: @.**> >
> Cool! The contract addresses here are actually not related to the >
visibility of nfts in veworld wallet. > Also, i see they are causing some
issues with the validation. Can you > just remove the key from the json ?
In general, they are not use for any > purpose at the moment. Thanks > > —
> Reply to this email directly, view it on GitHub > <#274 (comment)
<#274 (comment)>>, >
or unsubscribe >
https://github.com/notifications/unsubscribe-auth/A3P25TCFTYBO4ZSVOKFC6Y3ZJEK4NAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGE3DMMJZGY
<https://github.com/notifications/unsubscribe-auth/A3P25TCFTYBO4ZSVOKFC6Y3ZJEK4NAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBYGE3DMMJZGY>
> . > You are receiving this because you were mentioned.Message ID: > @.**>
>
I think you just deleted the entire folder. Please add it again with the
requested changes.
—
Reply to this email directly, view it on GitHub
<#274 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3P25TCCU2OA2GP56H4NXV3ZJGFDHAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBZGI4DKOJXGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thank you!
I really appreciate this.
…On Tue, Jun 25, 2024 at 8:41 AM Erik Nucibella ***@***.***> wrote:
Merged #274 <#274> into master.
—
Reply to this email directly, view it on GitHub
<#274 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3P25TAPYLG5L6TWKUTSPB3ZJGFUPAVCNFSM6AAAAABJURHP7OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI4DGNJZHAZTSMI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
manifest.json