Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a crit mission timer #710

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion assets/scripts/lobby/buttonEventListeners2.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ function greenButtonFunction() {
gameMode: $($('.gameModeSelect')[1]).val(),
timeouts: {
default: ((parseInt($('#startGameOptionsDefaultPhaseTimeoutMin').val()) * 60 + parseInt($('#startGameOptionsDefaultPhaseTimeoutSec').val())) * 1000).toString(),
assassination: ((parseInt($('#startGameOptionsAssassinationPhaseTimeoutMin').val()) * 60 + parseInt($('#startGameOptionsAssassinationPhaseTimeoutSec').val())) * 1000).toString()
critMission: ((parseInt($('#startGameOptionsCritMissionTimeoutMin').val()) * 60 + parseInt($('#startGameOptionsCritMissionTimeoutSec').val())) * 1000).toString(),
assassination: ((parseInt($('#startGameOptionsAssassinationPhaseTimeoutMin').val()) * 60 + parseInt($('#startGameOptionsAssassinationPhaseTimeoutSec').val())) * 1000).toString(),
},
anonymousMode: $('#startGameOptionsAnonymousMode')[0].checked,
};
Expand Down Expand Up @@ -236,6 +237,14 @@ $('#startGameOptionsDefaultPhaseTimeoutSec').on('change', () => {
handleTimeoutInput('#startGameOptionsDefaultPhaseTimeoutSec');
});

$('#startGameOptionsCritMissionTimeoutMin').on('change', () => {
handleTimeoutInput('#startGameOptionsCritMissionTimeoutMin');
});

$('#startGameOptionsCritMissionTimeoutSec').on('change', () => {
handleTimeoutInput('#startGameOptionsCritMissionTimeoutSec');
});

$('#startGameOptionsAssassinationPhaseTimeoutMin').on('change', () => {
handleTimeoutInput('#startGameOptionsAssassinationPhaseTimeoutMin');
});
Expand Down
5 changes: 4 additions & 1 deletion src/gameplay/game.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ class Game extends Room {
// Game misc variables
winner: Alliance = '';
requireSave = false;
critMission = false;

// TODO This shouldn't be here! Should be in Assassin file.
startAssassinationTime: Date;
Expand Down Expand Up @@ -550,10 +551,12 @@ class Game extends Room {
this.sendText(str, 'gameplay-text');

const timeouts = this.gameTimer.getTimeouts();
if (timeouts.assassination || timeouts.default) {
if (timeouts.assassination || timeouts.default || timeouts.critMission) {
this.sendText(
`Timeouts: Default = ${millisToStr(
timeouts.default,
)}, Critical Mission = ${millisToStr(
timeouts.critMission,
)}, Assassination = ${millisToStr(timeouts.assassination)}`,
'gameplay-text',
);
Expand Down
20 changes: 16 additions & 4 deletions src/gameplay/gameTimer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export interface Timeouts {
// All in milliseconds
default: number;
assassination: number;
critMission: number;
}

export class GameTimer {
Expand All @@ -22,6 +23,7 @@ export class GameTimer {
private timeoutSettings: Timeouts = {
default: 0,
assassination: 0,
critMission: 0,
};

private playersVotedPause: Set<string> = new Set();
Expand All @@ -36,6 +38,11 @@ export class GameTimer {
}

configureTimeouts(timeouts: Timeouts): void {
// Set crit mission timer to default if unset.
if (timeouts.critMission == 0) {
timeouts.critMission = timeouts.default;
}

this.timeoutSettings = timeouts;
}

Expand Down Expand Up @@ -111,10 +118,15 @@ export class GameTimer {
// Kinda sad to have direct knowledge of the phase here
// but not much we can do. We don't want the timeout settings
// in game.ts
let timerDuration =
this.game.phase === Phase.Assassination
? this.timeoutSettings.assassination
: this.timeoutSettings.default;
let timerDuration;

if (this.game.phase === Phase.Assassination) {
timerDuration = this.timeoutSettings.assassination;
} else if (this.game.critMission) {
timerDuration = this.timeoutSettings.critMission;
} else {
timerDuration = this.timeoutSettings.default;
}

// Timeout not enabled
if (timerDuration === 0) {
Expand Down
5 changes: 5 additions & 0 deletions src/gameplay/phases/common/votingMission.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,11 @@ class VotingMission implements IPhase {
}
}

// Critical mission if 2 fails
if (numOfFails == 2) {
this.thisRoom.critMission = true;
}

// game over if more than 3 fails or successes
if (numOfFails >= 3) {
this.thisRoom.winner = Alliance.Spy;
Expand Down
3 changes: 3 additions & 0 deletions src/gameplay/room.ts
Original file line number Diff line number Diff line change
Expand Up @@ -640,6 +640,9 @@ class Room {
rolesInStr += `<br>Ranked: ${this.ranked}`;
rolesInStr += `<br>Mute Spectators: ${this.muteSpectators}`;
rolesInStr += `<br>Default timeout: ${millisToStr(timeouts.default)}`;
rolesInStr += `<br>Critical Mission timeout: ${millisToStr(
timeouts.critMission,
)}`;
rolesInStr += `<br>Assassination timeout: ${millisToStr(
timeouts.assassination,
)}`;
Expand Down
1 change: 1 addition & 0 deletions src/sockets/sockets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1597,6 +1597,7 @@ function startGame(data) {
const timeouts = {
default: processTimeout(timeoutsStr.default),
assassination: processTimeout(timeoutsStr.assassination),
critMission: processTimeout(timeoutsStr.critMission),
};

if (
Expand Down
3 changes: 3 additions & 0 deletions src/views/lobby.ejs
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,9 @@
<label>Default Timeout: min: <input type="text" id="startGameOptionsDefaultPhaseTimeoutMin" style="width: 3em;" value="0" min="0" max="99"></label>
<label>sec: <input type="text" id="startGameOptionsDefaultPhaseTimeoutSec" style="width: 3em;" value="0" min="0" max="60"></label>
<br>
<label>Critical Mission Timeout: min: <input type="number" id="startGameOptionsCritMissionTimeoutMin" style="width: 3em;" value="0" min="0" max="99"></label>
<label>sec: <input type="text" id="startGameOptionsCritMissionTimeoutSec" style="width: 3em;" value="0" min="0" max="60"></label>
<br>
<label>Assassination Timeout: min: <input type="number" id="startGameOptionsAssassinationPhaseTimeoutMin" style="width: 3em;" value="0" min="0" max="99"></label>
<label>sec: <input type="text" id="startGameOptionsAssassinationPhaseTimeoutSec" style="width: 3em;" value="0" min="0" max="60"></label>
<br>
Expand Down
Loading