[WIP] New ProAvalon! #261
Open
[WIP] New ProAvalon! #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Logo - Navbar - Taako
- Combined constant colours into colortheme. Cleaner code. - Added Taako - Added OnlinePlayers - Added Chat - Added GameCard (still need to do ribbon for game status) - Prefixed all interfaces with 'I'
- Added timestamp for announcements - Renamed messages to announcements - All caps for headers - Moved useEffect to app.tsx - Remove previous event listener when useEffect is called - Added setMobileView reducer and mobileView state
- moved theme background and colors to app.tsx - refactored lobby code to include lobbyMobile and lobbyDesktop components - used React Hooks to display component in mobile view
- Removed individual declarations for width and height - Refactored lobbyMobile and lobbyDesktop to separate files - Renamed css classes with double unscores
- Fixed LobbyLeftPanel component rendering in LobbyDesktop - Added debounce to window resize event - Added scroll snap stop
- Data persistence in ./database_data/ - Added Readme information
- Added logo to top left - Added dynamic widths for side nav - Carousel slides are now correct height
- Data persistence in ./database_data/ - Added Readme information
- Data persistence in ./database_data/ - Added Readme information
Force merge.
- remove extra divs by passing classes straight to children
- fix left end of banner not aligning with chat - removed extra div around logo - replaced connect with useSelector - replaced wrapper div with more semantic header
- remove extraneous divs (container and style) - combine navRight ul into main nav's ul - replace anchors without links with buttons (for more accurate semantics)
- NavIndex is only used on the index page because logged in pages should be using Layout - this also removes an extraneous wrapper div by passing style straight to NavDesktop
- Turns out it was due to the cached binary being copied over? Not 100% sure. - Updated .dockerignore to be a blacklist instead of the previous whitelist. - Updated dockerfile for integration tests.
Add NyanCat's proavalon glossary into the chat UI. For now it is enabled for all players. There are a couple troublesome terms that I skipped implementing because they will cause issues with our current regex. Particullarly terms like m1.5 m2.3, etc. There are two main issues the period is treated as a word boundry so the regex that matches the shortest word will be shadowed by m1, etc.
- Base ECS set up - Need to work out how to do the typescripting for components and systems
- Assassin working minimally
- No longer remove all socket event listeners on socket. Was causing issues with waiting for socket events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a WORK IN PROGRESS. DO NOT MERGE.
This will be a long PR. I hope this PR can be used to keep record of relevant discussions and decisions made regarding the creation of this new website.