Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove method from Request Event #21

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

alavarello
Copy link
Contributor

The method is not used in the API gateway event version 1
https://docs.aws.amazon.com/apigateway/latest/developerguide/http-api-develop-integrations-lambda.html

This created conflict with middy event normalizer because it chooses the vpc mode and removes the query parameters

@vcfvct
Copy link
Owner

vcfvct commented Oct 18, 2023

Thanks for raising the issue. @alavarello

@blakejoy , do you think removing the method would break anything? I remember back then it was added for the C1 internal APIGW's argument. If all the lambdas now are behind ALB or AWS' API-Gateway, then this change should be good.

@vcfvct vcfvct merged commit 591b8cc into vcfvct:master Oct 28, 2023
2 checks passed
@vcfvct
Copy link
Owner

vcfvct commented Oct 30, 2023

@alavarello , released as v2.1.1 in npm 😄 , thanks

@blakejoy
Copy link
Collaborator

Didn't get a chance to review.. but I see no issues from my side 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants