feat: Introduce LocalLambdaGroup to manage multiple lambdas in a single server instance #20
Conversation
|
Love the idea. Thanks for the contribution. 😄 |
Thank you for your feedback on my contribution. I'm glad you like the idea! I've addressed your concerns. Let's merge this after #19 |
|
sorry for the late reply, it was a busy week. Thank you! |
|
Closed by accident. I've addressed to the comments you've made. |
This PR refactors the LocalLambda class to use
express.Router()and adds a new LocalLambdaGroup class for managing multiple lambdas.The LocalLambda now uses an instance of
express.Router()for handling requests, and it includes options for setting binary content-type headers, request context, and enable CORS.In addition, a new LocalLambdaGroup class has been added, which allows for multiple lambdas to be run simultaneously on the same server. It uses the LocalLambda class under the hood to handle each lambda's requests.
Both LocalLambda and LocalLambdaGroup have a
run()method that starts the server and listens for incoming requests. The LocalLambda instance can also be created separately if needed.I have tested this implementation thoroughly and all existing tests are passing. Please let me know if there is anything else I can do to help merge this PR.
PS. Based on my assessment, it would be best to hold off merging this PR until after #19 has been merged, as there may still be some additional work required on this PR. Therefore, I recommend deferring the merge until after the other PR has been completed.