complianted to releases api

vccw-team · Feb 6, 2017 · 0d8d970 · 0d8d970
1 parent 8b93ad0
commit 0d8d970
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/functions.php b/lib/functions.php
@@ -36,7 +36,9 @@ public static function get_latest_vccw_url()
 		$api = "https://api.github.com/repos/vccw-team/vccw/releases/latest";
 		$body = json_decode( self::download( $api ) );
 
-		if ( $body ) {
+		if ( ! empty( $body->assets[0] ) && ! empty( $body->assets[0]->browser_download_url ) ) {
+			return $body->assets[0]->browser_download_url;
+		} elseif ( $body ) {
 			return $body->zipball_url;
 		}
 	}

diff --git a/tests/test-functions.php b/tests/test-functions.php
@@ -2,6 +2,18 @@
 
 class Scaffold_VCCW_Test extends WP_UnitTestCase
 {
+	/**
+	 * Tests for the `Scaffold_VCCW::get_latest_vccw_url()`.
+	 *
+	 * @test
+	 * @since 1.3.0
+	 */
+	public function get_latest_vccw_url()
+	{
+		$url = Scaffold_VCCW::get_latest_vccw_url();
+		$this->assertRegExp( '#^https://github.com/vccw-team/vccw/releases/download#', $url );
+	}
+
 	/**
 	 * Tests for the `Scaffold_VCCW::rempty()`.
 	 *