Return *DetachError instead of DetachError

This works as a pointer or non-pointer, but it's easier to enforce consistency by fulfilling the error interface with a pointer receiver.
vcabbage · Jul 26, 2018 · 4b9cda8 · 4b9cda8
1 parent 5dba116
commit 4b9cda8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/client.go b/client.go
@@ -774,7 +774,7 @@ type DetachError struct {
 	RemoteError *Error
 }
 
-func (e DetachError) Error() string {
+func (e *DetachError) Error() string {
 	return fmt.Sprintf("link detached, reason: %+v", e.RemoteError)
 }
 
@@ -1198,7 +1198,7 @@ func (l *link) muxHandleFrame(fr frameBody) error {
 		// set detach received and close link
 		l.detachReceived = true
 
-		return errorWrapf(DetachError{fr.Error}, "received detach frame")
+		return errorWrapf(&DetachError{fr.Error}, "received detach frame")
 
 	case *performDisposition:
 		debug(3, "RX: %s", fr)