Skip to content

Answer to a ping frame is a pong frame with the same content #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Answer to a ping frame is a pong frame with the same content #141

wants to merge 3 commits into from

Conversation

mebsout
Copy link
Contributor

@mebsout mebsout commented Jan 20, 2025

WebSocket specs specifies that:

A Pong frame sent in response to a Ping frame must have identical
"Application data" as found in the message body of the Ping frame
being replied to.

This MR makes the helpers offered by this library follow this.

@copy
Copy link
Collaborator

copy commented Jul 4, 2025

LGTM.

Could you rebase? (async support has been removed, the rest should be fine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mebsout @copy