Skip to content

Commit

Permalink
Testing upb fix from upstream
Browse files Browse the repository at this point in the history
Ref: bazelbuild/bazel#11885 (comment)

Signed-off-by: Vincent Batts <[email protected]>
  • Loading branch information
vbatts committed Sep 11, 2020
1 parent 1111ce0 commit 8cd275f
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 1 deletion.
42 changes: 42 additions & 0 deletions b3ac8f60973ba60d578ae6a653cdd993a2d206d7.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
From b3ac8f60973ba60d578ae6a653cdd993a2d206d7 Mon Sep 17 00:00:00 2001
From: Yun Peng <[email protected]>
Date: Fri, 11 Sep 2020 07:39:36 -0700
Subject: [PATCH] Patch upb to fix build error with gcc 10

Fixes #12056

This is a replacement of https://github.com/bazelbuild/bazel/pull/12077 after an unsuccessful attempt to upgrade upb version.

Closes #12083.

PiperOrigin-RevId: 331145667
---
WORKSPACE | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/WORKSPACE b/WORKSPACE
index 117dcb500de..65d6663b50a 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -1056,6 +1056,21 @@ register_local_rc_exe_toolchains()

register_toolchains("//src/main/res:empty_rc_toolchain")

+# Patch upb for grpc due to https://github.com/bazelbuild/bazel/issues/12056
+# TODO: Remove the following after upgrading grpc to a newer version that's not
+# affected by this issue.
+http_archive(
+ name = "upb",
+ sha256 = "61d0417abd60e65ed589c9deee7c124fe76a4106831f6ad39464e1525cef1454",
+ patches = ["//third_party/grpc:upb_gcc10_fix.patch"],
+ patch_args = ["-p1"],
+ strip_prefix = "upb-9effcbcb27f0a665f9f345030188c0b291e32482",
+ urls = [
+ "https://mirror.bazel.build/github.com/protocolbuffers/upb/archive/9effcbcb27f0a665f9f345030188c0b291e32482.tar.gz",
+ "https://github.com/protocolbuffers/upb/archive/9effcbcb27f0a665f9f345030188c0b291e32482.tar.gz",
+ ],
+)
+
http_archive(
name = "com_github_grpc_grpc",
urls = [
4 changes: 3 additions & 1 deletion bazel.spec
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,15 @@

Name: bazel3
Version: 3.5.0
Release: 1%{?dist}
Release: 2%{?dist}
Summary: Correct, reproducible, and fast builds for everyone.
License: Apache License 2.0
URL: http://bazel.io/
Source0: https://github.com/bazelbuild/bazel/releases/download/%{version}/bazel-%{version}-dist.zip

# FIXME: Java 11 log.warning generates backtrace
Patch1: bazel-1.0.0-log-warning.patch
Patch2: https://github.com/bazelbuild/bazel/commit/b3ac8f60973ba60d578ae6a653cdd993a2d206d7.patch

# for folks with 'bazel' v1 package installed
Conflicts: bazel
Expand Down Expand Up @@ -50,6 +51,7 @@ Correct, reproducible, and fast builds for everyone.
%setup -q -c -n bazel-%{version}

%patch1 -p0
%patch2 -p1


%build
Expand Down

0 comments on commit 8cd275f

Please sign in to comment.