Fix default number of CPUs available.

vathymut · Jan 17, 2022 · ca2d98c · ca2d98c
1 parent 63153d4
commit ca2d98c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.Rbuildignore b/.Rbuildignore
@@ -9,4 +9,5 @@
 ^NEWS\.md$
 ^docs$
 ^README.md$
-^README.Rmd$
+^README.Rmd$
+^CRAN-SUBMISSION$
diff --git a/R/rf-helpers.R b/R/rf-helpers.R
@@ -26,7 +26,6 @@ classifier_args <- function(data,
     probability = TRUE,
     write.forest = TRUE,
     replace = FALSE,
-    num.threads = parallel::detectCores() - 1L,
     save.memory = FALSE,
     respect.unordered.factors = TRUE,
     verbose = FALSE,
@@ -59,7 +58,6 @@ residual_args <- function(data, num_trees = 500L, response_name = "label") {
     importance = "none",
     write.forest = TRUE,
     replace = FALSE,
-    num.threads = parallel::detectCores() - 1L,
     save.memory = FALSE,
     respect.unordered.factors = TRUE,
     verbose = FALSE,

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,4 +1,10 @@
-# Test environments
+## Resubmission
+
+This is a resubmission. In this version, I changed default argument to satisfy
+Julia Haider's request: "Please ensure that you do not use more than 2 cores in
+your examples [...]. Please fix and resubmit."
+
+## Test environments
 
 * local Windows 10 x64, R installation, R 4.0.5
 * R-hub Ubuntu Linux 20.04.1 LTS, R-release, GCC