Skip to content

Conversation

@OlivierFL
Copy link
Collaborator

@OlivierFL OlivierFL commented Oct 21, 2025

Description

Review by commit

Add Pool Storage Repositories page.

Screenshots

image image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

If you are an external contributor, you can skip this part. Simply create the pull request, and we'll get back to you as soon as possible.

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@OlivierFL OlivierFL self-assigned this Oct 21, 2025
@OlivierFL OlivierFL force-pushed the xo6/pool-storage-page branch 2 times, most recently from 167cb56 to 7a25e60 Compare October 21, 2025 09:27
@OlivierFL OlivierFL requested a review from J0ris-K October 21, 2025 09:28
@OlivierFL OlivierFL force-pushed the xo6/pool-storage-page branch 2 times, most recently from 77a39f5 to 2eeb1d2 Compare October 23, 2025 11:55
@J0ris-K J0ris-K requested a review from Elise-FZI October 27, 2025 16:12
@OlivierFL OlivierFL force-pushed the xo6/pool-storage-page branch 7 times, most recently from 96942ba to a49b47e Compare November 7, 2025 09:56
@OlivierFL OlivierFL force-pushed the xo6/pool-storage-page branch 2 times, most recently from 92e885f to 62bffaa Compare November 14, 2025 15:54
@OlivierFL OlivierFL force-pushed the xo6/pool-storage-page branch from 62bffaa to def9164 Compare November 17, 2025 09:52
@OlivierFL OlivierFL force-pushed the xo6/pool-storage-page branch from def9164 to e635859 Compare November 17, 2025 13:54
@OlivierFL OlivierFL force-pushed the xo6/pool-storage-page branch from e635859 to 2ef32fd Compare November 17, 2025 13:56
@OlivierFL OlivierFL merged commit 5fb5e63 into master Nov 17, 2025
1 check passed
@OlivierFL OlivierFL deleted the xo6/pool-storage-page branch November 17, 2025 14:01
MelissaFrncJrg pushed a commit that referenced this pull request Nov 24, 2025
* fix reactivity issue in progress.util

* update VtsProgressBar component to display progress bar with no ruler

* create and use ProgressCell in Table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants