Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backups): show a toggle to enable snapshot destroy with CBT #7796

Closed
wants to merge 7 commits into from
Closed

feat(backups): show a toggle to enable snapshot destroy with CBT #7796

wants to merge 7 commits into from

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Jul 2, 2024 •
edited
Loading

Description

image

  • add a toggle to purge snapshot data instead of relying on a config file
  • this toggle can't be enabled if NBD is not used
  • preferNbd enabled don't mean it will be used in all the case, for example if there are no NBD enabled network
  • can't be used if there are rolling snapshot

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp requested a review from MathieuRA July 2, 2024 13:29
MathieuRA
MathieuRA requested changes Jul 2, 2024
View reviewed changes
packages/xo-web/src/common/intl/messages.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/backup/new/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/backup/new/index.js Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp marked this pull request as ready for review July 3, 2024 06:46
@fbeauchamp fbeauchamp requested a review from MathieuRA July 3, 2024 06:46
MathieuRA
MathieuRA requested changes Jul 3, 2024
View reviewed changes
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/backup/new/index.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/backup/new/index.js Outdated Show resolved Hide resolved
@fbeauchamp
Copy link
Collaborator Author

superseeded by #7805

@fbeauchamp fbeauchamp closed this Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathieuRA MathieuRA MathieuRA requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbeauchamp @MathieuRA